Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump min node version to 14 #181

Merged
merged 1 commit into from
Dec 15, 2022
Merged

feat: bump min node version to 14 #181

merged 1 commit into from
Dec 15, 2022

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Dec 9, 2022

PR summary

This commit modifies the build to use node versions 14, 16 and 18, and bumps our min version of node from 12 to 14.

Signed-off-by: Phil Adams [email protected]

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This commit modifies the build to use node versions
14, 16 and 18, and bumps our min version of node from
12 to 14.

Signed-off-by: Phil Adams <[email protected]>
@padamstx padamstx self-assigned this Dec 9, 2022
@padamstx padamstx requested a review from dpopp07 December 9, 2022 16:18
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@padamstx padamstx merged commit a5808d6 into main Dec 15, 2022
@padamstx padamstx deleted the bump-node branch December 15, 2022 21:39
ibm-devx-sdk pushed a commit that referenced this pull request Dec 15, 2022
# [0.30.0](v0.29.2...v0.30.0) (2022-12-15)

### Features

* bump min node version to 14 ([#181](#181)) ([a5808d6](a5808d6))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants